[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

src/Ryujinx.HLE/HOS/Services/Time/TimeZone/TimeZoneManager.cs

@@ -7,20 +7,20 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
 {
     class TimeZoneManager
     {
-        private bool                 _isInitialized;
-        private Box<TimeZoneRule>    _myRules;
-        private string               _deviceLocationName;
-        private UInt128              _timeZoneRuleVersion;
-        private uint                 _totalLocationNameCount;
+        private bool _isInitialized;
+        private Box<TimeZoneRule> _myRules;
+        private string _deviceLocationName;
+        private UInt128 _timeZoneRuleVersion;
+        private uint _totalLocationNameCount;
         private SteadyClockTimePoint _timeZoneUpdateTimePoint;
-        private readonly object      _lock = new();
+        private readonly object _lock = new();
 
         public TimeZoneManager()
         {
-            _isInitialized       = false;
-            _deviceLocationName  = "UTC";
+            _isInitialized = false;
+            _deviceLocationName = "UTC";
             _timeZoneRuleVersion = new UInt128();
-            _myRules             = new Box<TimeZoneRule>();
+            _myRules = new Box<TimeZoneRule>();
 
             _timeZoneUpdateTimePoint = SteadyClockTimePoint.GetRandom();
         }
@@ -56,7 +56,7 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
                 if (_isInitialized)
                 {
                     deviceLocationName = _deviceLocationName;
-                    result             = ResultCode.Success;
+                    result = ResultCode.Success;
                 }
             }
 
@@ -69,15 +69,15 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
 
             lock (_lock)
             {
-                Box<TimeZoneRule> rules = new Box<TimeZoneRule>();
+                Box<TimeZoneRule> rules = new();
 
                 bool timeZoneConversionSuccess = TimeZone.ParseTimeZoneBinary(ref rules.Data, timeZoneBinaryStream);
 
                 if (timeZoneConversionSuccess)
                 {
                     _deviceLocationName = locationName;
-                    _myRules            = rules;
-                    result              = ResultCode.Success;
+                    _myRules = rules;
+                    result = ResultCode.Success;
                 }
             }
 
@@ -103,7 +103,7 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
                 if (_isInitialized)
                 {
                     totalLocationNameCount = _totalLocationNameCount;
-                    result                 = ResultCode.Success;
+                    result = ResultCode.Success;
                 }
             }
 
@@ -119,7 +119,7 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
                 if (_isInitialized || bypassUninitialized)
                 {
                     _timeZoneUpdateTimePoint = timeZoneUpdatedTimePoint;
-                    result                   = ResultCode.Success;
+                    result = ResultCode.Success;
                 }
             }
 
@@ -135,12 +135,12 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
                 if (_isInitialized)
                 {
                     timeZoneUpdatedTimePoint = _timeZoneUpdateTimePoint;
-                    result                   = ResultCode.Success;
+                    result = ResultCode.Success;
                 }
                 else
                 {
                     timeZoneUpdatedTimePoint = SteadyClockTimePoint.GetRandom();
-                    result                   = ResultCode.UninitializedClock;
+                    result = ResultCode.UninitializedClock;
                 }
             }
 
@@ -181,12 +181,12 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
                 if (_isInitialized)
                 {
                     timeZoneRuleVersion = _timeZoneRuleVersion;
-                    result              = ResultCode.Success;
+                    result = ResultCode.Success;
                 }
                 else
                 {
                     timeZoneRuleVersion = new UInt128();
-                    result              = ResultCode.UninitializedClock;
+                    result = ResultCode.UninitializedClock;
                 }
             }
 
@@ -206,7 +206,7 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
                 else
                 {
                     calendar = new CalendarInfo();
-                    result   = ResultCode.UninitializedClock;
+                    result = ResultCode.UninitializedClock;
                 }
             }
 
@@ -238,7 +238,7 @@ namespace Ryujinx.HLE.HOS.Services.Time.TimeZone
                 else
                 {
                     posixTime = 0;
-                    result    = ResultCode.UninitializedClock;
+                    result = ResultCode.UninitializedClock;
                 }
             }