From 022e61b2d05ab79a510a8c7f26c32df61979eb93 Mon Sep 17 00:00:00 2001
From: Otavio Pliger <git@otaviopliger.com>
Date: Sat, 22 Jul 2023 16:06:56 +0700
Subject: [PATCH] Don't display empty image preview if thumbnail image is null

---
 .../android/ui/displayitems/LinkCardStatusDisplayItem.java    | 3 +++
 mastodon/src/main/res/layout/display_item_link_card.xml       | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/LinkCardStatusDisplayItem.java b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/LinkCardStatusDisplayItem.java
index 59b08451a..84dc32df7 100644
--- a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/LinkCardStatusDisplayItem.java
+++ b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/LinkCardStatusDisplayItem.java
@@ -87,7 +87,10 @@ public class LinkCardStatusDisplayItem extends StatusDisplayItem{
 				crossfadeDrawable.setBlurhashDrawable(card.blurhashPlaceholder);
 				crossfadeDrawable.setCrossfadeAlpha(item.status.spoilerRevealed ? 0f : 1f);
 				photo.setImageDrawable(crossfadeDrawable);
+				photo.setVisibility(View.VISIBLE);
 				didClear=false;
+			} else {
+				photo.setVisibility(View.GONE);
 			}
 
 			// if there's no image, we don't want to cover the inset borders
diff --git a/mastodon/src/main/res/layout/display_item_link_card.xml b/mastodon/src/main/res/layout/display_item_link_card.xml
index fae9dade6..31ac96418 100644
--- a/mastodon/src/main/res/layout/display_item_link_card.xml
+++ b/mastodon/src/main/res/layout/display_item_link_card.xml
@@ -8,14 +8,14 @@
 	<org.joinmastodon.android.ui.views.MaxWidthFrameLayout
 		android:id="@+id/inner"
 		android:layout_width="match_parent"
-		android:layout_height="250dp"
+		android:layout_height="match_parent"
 		android:layout_gravity="center_horizontal"
 		android:foreground="?android:selectableItemBackground"
 		android:maxWidth="@dimen/layout_max_width">
 		<ImageView
 			android:id="@+id/photo"
 			android:layout_width="match_parent"
-			android:layout_height="match_parent"
+			android:layout_height="250dp"
 			android:scaleType="centerCrop"
 			tools:src="#0f0"/>
 		<LinearLayout