From 5432f2590c0968cf8d90e82f9aac822a704244d3 Mon Sep 17 00:00:00 2001 From: sk Date: Sun, 4 Jun 2023 05:00:48 +0200 Subject: [PATCH] fine-tune footer layout --- .../displayitems/TextStatusDisplayItem.java | 12 +++++----- mastodon/src/main/res/drawable/ic_boost.xml | 6 ++--- ...c_fluent_arrow_repeat_all_24sp_regular.xml | 3 +++ ...uent_arrow_repeat_all_24sp_very_filled.xml | 23 +++++++++++++++++++ ...uent_arrow_repeat_all_off_24sp_regular.xml | 3 +++ .../ic_fluent_bookmark_24sp_filled.xml | 3 +++ .../ic_fluent_bookmark_24sp_regular.xml | 3 +++ .../ic_fluent_bookmark_24sp_selector.xml | 8 +++++++ .../ic_fluent_chat_multiple_24sp_regular.xml | 3 +++ ...fluent_chat_multiple_24sp_regular_text.xml | 15 ++++++++++++ ...luent_chat_multiple_24sp_selector_text.xml | 6 +++++ .../drawable/ic_fluent_share_24sp_regular.xml | 3 +++ .../drawable/ic_fluent_star_24sp_filled.xml | 3 +++ .../drawable/ic_fluent_star_24sp_regular.xml | 3 +++ .../drawable/ic_fluent_star_24sp_selector.xml | 8 +++++++ .../main/res/layout/display_item_footer.xml | 23 +++++++++++-------- 16 files changed, 106 insertions(+), 19 deletions(-) create mode 100644 mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_24sp_regular.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_24sp_very_filled.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_off_24sp_regular.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_filled.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_regular.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_selector.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_regular.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_regular_text.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_selector_text.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_share_24sp_regular.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_star_24sp_filled.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_star_24sp_regular.xml create mode 100644 mastodon/src/main/res/drawable/ic_fluent_star_24sp_selector.xml diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/TextStatusDisplayItem.java b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/TextStatusDisplayItem.java index 77e1b1c5a..a6d419c49 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/TextStatusDisplayItem.java +++ b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/TextStatusDisplayItem.java @@ -238,12 +238,12 @@ public class TextStatusDisplayItem extends StatusDisplayItem{ // remove additional padding when (transparently padded) translate button is visible int pos = getAbsoluteAdapterPosition(); - itemView.setPadding(itemView.getPaddingLeft(), itemView.getPaddingTop(), itemView.getPaddingRight(), - (translateVisible && - item.parentFragment.getDisplayItems().size() >= pos + 1 && - item.parentFragment.getDisplayItems().get(pos + 1) instanceof FooterStatusDisplayItem) - ? 0 : V.dp(12) - ); + boolean nextIsFooter = item.parentFragment.getDisplayItems().size() >= pos + 1 && + item.parentFragment.getDisplayItems().get(pos + 1) instanceof FooterStatusDisplayItem; + int bottomPadding = (translateVisible && nextIsFooter) ? 0 + : nextIsFooter ? V.dp(8) + : V.dp(12); + itemView.setPadding(itemView.getPaddingLeft(), itemView.getPaddingTop(), itemView.getPaddingRight(), bottomPadding); if (!GlobalUserPreferences.collapseLongPosts) { textScrollView.setLayoutParams(wrapParams); diff --git a/mastodon/src/main/res/drawable/ic_boost.xml b/mastodon/src/main/res/drawable/ic_boost.xml index 64f632e5b..a14cebaa2 100644 --- a/mastodon/src/main/res/drawable/ic_boost.xml +++ b/mastodon/src/main/res/drawable/ic_boost.xml @@ -1,6 +1,6 @@ - - - + + + \ No newline at end of file diff --git a/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_24sp_regular.xml b/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_24sp_regular.xml new file mode 100644 index 000000000..ee22e43a2 --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_24sp_regular.xml @@ -0,0 +1,3 @@ + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_24sp_very_filled.xml b/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_24sp_very_filled.xml new file mode 100644 index 000000000..15d5e44f6 --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_24sp_very_filled.xml @@ -0,0 +1,23 @@ + + + + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_off_24sp_regular.xml b/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_off_24sp_regular.xml new file mode 100644 index 000000000..bf315efcb --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_arrow_repeat_all_off_24sp_regular.xml @@ -0,0 +1,3 @@ + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_filled.xml b/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_filled.xml new file mode 100644 index 000000000..2412d01ac --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_filled.xml @@ -0,0 +1,3 @@ + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_regular.xml b/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_regular.xml new file mode 100644 index 000000000..c32c5603b --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_regular.xml @@ -0,0 +1,3 @@ + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_selector.xml b/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_selector.xml new file mode 100644 index 000000000..9e81bec2b --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_bookmark_24sp_selector.xml @@ -0,0 +1,8 @@ + + + + + + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_regular.xml b/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_regular.xml new file mode 100644 index 000000000..98a4373b4 --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_regular.xml @@ -0,0 +1,3 @@ + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_regular_text.xml b/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_regular_text.xml new file mode 100644 index 000000000..3adbf88f5 --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_regular_text.xml @@ -0,0 +1,15 @@ + + + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_selector_text.xml b/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_selector_text.xml new file mode 100644 index 000000000..4e3f84614 --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_chat_multiple_24sp_selector_text.xml @@ -0,0 +1,6 @@ + + + + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_share_24sp_regular.xml b/mastodon/src/main/res/drawable/ic_fluent_share_24sp_regular.xml new file mode 100644 index 000000000..b2e6ddd0b --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_share_24sp_regular.xml @@ -0,0 +1,3 @@ + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_star_24sp_filled.xml b/mastodon/src/main/res/drawable/ic_fluent_star_24sp_filled.xml new file mode 100644 index 000000000..92118cbfb --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_star_24sp_filled.xml @@ -0,0 +1,3 @@ + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_star_24sp_regular.xml b/mastodon/src/main/res/drawable/ic_fluent_star_24sp_regular.xml new file mode 100644 index 000000000..8c946162a --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_star_24sp_regular.xml @@ -0,0 +1,3 @@ + + + diff --git a/mastodon/src/main/res/drawable/ic_fluent_star_24sp_selector.xml b/mastodon/src/main/res/drawable/ic_fluent_star_24sp_selector.xml new file mode 100644 index 000000000..faf7363fa --- /dev/null +++ b/mastodon/src/main/res/drawable/ic_fluent_star_24sp_selector.xml @@ -0,0 +1,8 @@ + + + + + + + + diff --git a/mastodon/src/main/res/layout/display_item_footer.xml b/mastodon/src/main/res/layout/display_item_footer.xml index dcd358586..3f92635db 100644 --- a/mastodon/src/main/res/layout/display_item_footer.xml +++ b/mastodon/src/main/res/layout/display_item_footer.xml @@ -10,7 +10,9 @@ + android:layout_height="wrap_content" + android:paddingHorizontal="11sp"> + + android:paddingVertical="12dp"> + android:paddingVertical="12dp"> + android:paddingVertical="12dp"> + android:paddingVertical="12dp"> @@ -118,13 +120,14 @@ android:id="@+id/share_btn" android:layout_width="wrap_content" android:layout_height="match_parent" - android:paddingHorizontal="16dp"> + android:paddingHorizontal="16dp" + android:paddingVertical="12dp">