From d6bb5b7b3a41c555138de44d55e9b9ff306a11d8 Mon Sep 17 00:00:00 2001
From: Grishka <git@grishka.me>
Date: Thu, 7 Apr 2022 18:26:45 +0300
Subject: [PATCH] Use sp units for text sizes where they don't break layout

---
 mastodon/src/main/res/layout/display_item_text.xml           | 1 +
 mastodon/src/main/res/layout/fragment_compose.xml            | 2 ++
 mastodon/src/main/res/layout/fragment_profile.xml            | 3 +++
 mastodon/src/main/res/layout/item_instance_catalog.xml       | 5 ++++-
 mastodon/src/main/res/layout/item_profile_about.xml          | 2 ++
 mastodon/src/main/res/layout/item_report_choice.xml          | 2 ++
 mastodon/src/main/res/layout/item_settings_footer.xml        | 5 +++--
 mastodon/src/main/res/layout/item_settings_header.xml        | 2 +-
 mastodon/src/main/res/layout/item_settings_switch.xml        | 2 +-
 mastodon/src/main/res/layout/item_settings_text.xml          | 2 +-
 mastodon/src/main/res/layout/item_settings_theme_subitem.xml | 4 +++-
 11 files changed, 23 insertions(+), 7 deletions(-)

diff --git a/mastodon/src/main/res/layout/display_item_text.xml b/mastodon/src/main/res/layout/display_item_text.xml
index 294f254f2..90d06c6a8 100644
--- a/mastodon/src/main/res/layout/display_item_text.xml
+++ b/mastodon/src/main/res/layout/display_item_text.xml
@@ -12,6 +12,7 @@
 		android:id="@+id/text"
 		android:layout_width="match_parent"
 		android:layout_height="wrap_content"
+		android:textSize="16sp"
 		android:textAppearance="@style/m3_body_large"/>
 
 	<LinearLayout
diff --git a/mastodon/src/main/res/layout/fragment_compose.xml b/mastodon/src/main/res/layout/fragment_compose.xml
index b76889a99..83aaee434 100644
--- a/mastodon/src/main/res/layout/fragment_compose.xml
+++ b/mastodon/src/main/res/layout/fragment_compose.xml
@@ -28,6 +28,7 @@
 				android:background="@drawable/bg_cw_edit"
 				android:padding="16dp"
 				android:minHeight="56dp"
+				android:textSize="16sp"
 				tools:visibility="visible"/>
 
 			<TextView
@@ -96,6 +97,7 @@
 					android:paddingRight="16dp"
 					android:paddingBottom="16dp"
 					android:textAppearance="@style/m3_body_large"
+					android:textSize="16sp"
 					android:gravity="top"
 					android:background="@null"
 					android:hint="@string/compose_hint"
diff --git a/mastodon/src/main/res/layout/fragment_profile.xml b/mastodon/src/main/res/layout/fragment_profile.xml
index 4f86d3d69..9c1ca1ba0 100644
--- a/mastodon/src/main/res/layout/fragment_profile.xml
+++ b/mastodon/src/main/res/layout/fragment_profile.xml
@@ -189,6 +189,7 @@
 						android:layout_marginTop="8dp"
 						android:layout_marginRight="16dp"
 						android:textAppearance="@style/m3_body_large"
+						android:textSize="16sp"
 						tools:text="Founder, CEO and lead developer @Mastodon, Germany." />
 
 					<EditText
@@ -201,6 +202,7 @@
 						android:layout_marginTop="16dp"
 						android:layout_toStartOf="@id/profile_action_btn_wrap"
 						android:textAppearance="@style/m3_body_large"
+						android:textSize="16sp"
 						android:background="@drawable/edit_text_border"
 						android:inputType="textPersonName|textCapWords"
 						android:visibility="gone"
@@ -216,6 +218,7 @@
 						android:layout_marginTop="8dp"
 						android:layout_marginRight="16dp"
 						android:textAppearance="@style/m3_body_large"
+						android:textSize="16sp"
 						android:background="@drawable/edit_text_border"
 						android:inputType="textMultiLine|textCapSentences"
 						android:visibility="gone"
diff --git a/mastodon/src/main/res/layout/item_instance_catalog.xml b/mastodon/src/main/res/layout/item_instance_catalog.xml
index cc8cd528c..3adc65d4d 100644
--- a/mastodon/src/main/res/layout/item_instance_catalog.xml
+++ b/mastodon/src/main/res/layout/item_instance_catalog.xml
@@ -20,7 +20,7 @@
 	<TextView
 		android:id="@+id/title"
 		android:layout_width="match_parent"
-		android:layout_height="24dp"
+		android:layout_height="wrap_content"
 		android:layout_toEndOf="@id/radiobtn"
 		android:layout_alignParentTop="true"
 		android:layout_marginBottom="4dp"
@@ -28,6 +28,8 @@
 		android:singleLine="true"
 		android:ellipsize="end"
 		android:gravity="center_vertical"
+		android:textSize="16sp"
+		android:minHeight="24dp"
 		tools:text="mastodon.social"/>
 
 	<TextView
@@ -39,6 +41,7 @@
 		android:layout_marginBottom="8dp"
 		android:textAppearance="@style/m3_body_medium"
 		android:textColor="?android:textColorSecondary"
+		android:textSize="14sp"
 		tools:text="General-purpose server run by the lead developer of Mastodon"/>
 
 	<TextView
diff --git a/mastodon/src/main/res/layout/item_profile_about.xml b/mastodon/src/main/res/layout/item_profile_about.xml
index 75459e896..fc5759683 100644
--- a/mastodon/src/main/res/layout/item_profile_about.xml
+++ b/mastodon/src/main/res/layout/item_profile_about.xml
@@ -16,6 +16,7 @@
 		android:textAppearance="@style/m3_label_medium"
 		android:minHeight="16dp"
 		android:textAllCaps="true"
+		android:textSize="12sp"
 		tools:text="Field title"/>
 
 	<org.joinmastodon.android.ui.views.LinkedTextView
@@ -23,6 +24,7 @@
 		android:layout_width="match_parent"
 		android:layout_height="wrap_content"
 		android:textAppearance="@style/m3_body_large"
+		android:textSize="16sp"
 		tools:text="Field value"/>
 
 </LinearLayout>
\ No newline at end of file
diff --git a/mastodon/src/main/res/layout/item_report_choice.xml b/mastodon/src/main/res/layout/item_report_choice.xml
index 5241df17d..27ecd7588 100644
--- a/mastodon/src/main/res/layout/item_report_choice.xml
+++ b/mastodon/src/main/res/layout/item_report_choice.xml
@@ -21,6 +21,7 @@
 		android:layout_toEndOf="@id/checkbox"
 		android:layout_marginStart="16dp"
 		android:textAppearance="@style/m3_title_medium"
+		android:textSize="16sp"
 		tools:text="Title"/>
 
 	<TextView
@@ -32,6 +33,7 @@
 		android:layout_marginStart="16dp"
 		android:textAppearance="@style/m3_body_medium"
 		android:textColor="?android:textColorSecondary"
+		android:textSize="14sp"
 		tools:text="Subtitle"/>
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/mastodon/src/main/res/layout/item_settings_footer.xml b/mastodon/src/main/res/layout/item_settings_footer.xml
index 1f39e51e0..555cdb9ee 100644
--- a/mastodon/src/main/res/layout/item_settings_footer.xml
+++ b/mastodon/src/main/res/layout/item_settings_footer.xml
@@ -2,8 +2,9 @@
 <TextView xmlns:android="http://schemas.android.com/apk/res/android"
 	xmlns:tools="http://schemas.android.com/tools"
 	android:layout_width="match_parent"
-	android:layout_height="24dp"
-	android:textSize="16dp"
+	android:layout_height="wrap_content"
+	android:textSize="16sp"
+	android:minHeight="24dp"
 	android:textColor="?android:textColorSecondary"
 	android:gravity="center"
 	tools:text="Visual appearance"/>
\ No newline at end of file
diff --git a/mastodon/src/main/res/layout/item_settings_header.xml b/mastodon/src/main/res/layout/item_settings_header.xml
index f73ce0ba0..d0cca7756 100644
--- a/mastodon/src/main/res/layout/item_settings_header.xml
+++ b/mastodon/src/main/res/layout/item_settings_header.xml
@@ -3,7 +3,7 @@
 	xmlns:tools="http://schemas.android.com/tools"
 	android:layout_width="match_parent"
 	android:layout_height="wrap_content"
-	android:textSize="14dp"
+	android:textSize="14sp"
 	android:fontFamily="sans-serif-medium"
 	android:textColor="?android:colorAccent"
 	android:padding="16dp"
diff --git a/mastodon/src/main/res/layout/item_settings_switch.xml b/mastodon/src/main/res/layout/item_settings_switch.xml
index 6bec213ce..d3fc123cd 100644
--- a/mastodon/src/main/res/layout/item_settings_switch.xml
+++ b/mastodon/src/main/res/layout/item_settings_switch.xml
@@ -22,7 +22,7 @@
 		android:layout_width="0dp"
 		android:layout_height="wrap_content"
 		android:layout_weight="1"
-		android:textSize="16dp"
+		android:textSize="16sp"
 		android:textColor="?android:textColorPrimary"
 		android:singleLine="true"
 		android:ellipsize="end"
diff --git a/mastodon/src/main/res/layout/item_settings_text.xml b/mastodon/src/main/res/layout/item_settings_text.xml
index bfaac1048..45d35542e 100644
--- a/mastodon/src/main/res/layout/item_settings_text.xml
+++ b/mastodon/src/main/res/layout/item_settings_text.xml
@@ -6,7 +6,7 @@
 	android:paddingLeft="16dp"
 	android:paddingRight="16dp"
 	android:gravity="center_vertical"
-	android:textSize="16dp"
+	android:textSize="16sp"
 	android:textColor="?android:textColorPrimary"
 	android:singleLine="true"
 	android:ellipsize="end"
diff --git a/mastodon/src/main/res/layout/item_settings_theme_subitem.xml b/mastodon/src/main/res/layout/item_settings_theme_subitem.xml
index 9abc17caa..93d24295f 100644
--- a/mastodon/src/main/res/layout/item_settings_theme_subitem.xml
+++ b/mastodon/src/main/res/layout/item_settings_theme_subitem.xml
@@ -17,9 +17,11 @@
 	<TextView
 		android:id="@+id/text"
 		android:layout_width="match_parent"
-		android:layout_height="20dp"
+		android:layout_height="wrap_content"
 		android:layout_marginTop="8dp"
 		android:textAppearance="@style/m3_body_medium"
+		android:textSize="14sp"
+		android:minHeight="20dp"
 		android:gravity="center"
 		android:singleLine="true"
 		android:ellipsize="end"